Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qiime qzv visualisation extractor #4834

Merged
merged 2 commits into from
May 13, 2024

Conversation

bernt-matthias
Copy link
Contributor

the qiime2 display application (view.qiime2.org) does not work for non-public Galaxy instances. This is a workaround.

qiime2 viz artifacts are just zip files which also contain the html + data + files (which is shown at the view website). So this tool is equivalent

If I find the time I will explore the possibility to do the same with a generic / viz plugin .. at least for so long (and maybe for workflows) the tool will be useful.

Thanks to @EngyNasr for the discussion and help.

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

the qiime2 display application (view.qiime2.org) does not work for non-public Galaxy
instances. This is a workaround.

qiime2 viz artifacts are just zip files which also contain the html + data + files
(which is shown at the view website). So this tool is equivalent

If I find the time I will explore the possibility to do the same with a
generic / viz plugin .. at least for so long (and maybe for workflows)
the tool will be useful.
tools/qiime_extract_viz/.shed.yml Outdated Show resolved Hide resolved
tools/qiime_extract_viz/qiime_extract_viz.xml Outdated Show resolved Hide resolved
@bernt-matthias bernt-matthias marked this pull request as draft October 8, 2022 14:22
@bernt-matthias
Copy link
Contributor Author

Put this on draft .. want to finish the discussion with the qiime2 developers first qiime2/galaxy-tools#38 (comment)

@shiltemann
Copy link
Member

@bernt-matthias I just wrote this exact same tool, then found this PR. What are your thoughts on this currently? Should we try to get this in?

The "display at qiime2view" links are still broken (galaxyproject/galaxy#17658) in Galaxy, pasting shared dataset URLs in qiime2view manually is also broken due to CORS settings, so currently no good way to view qzv files in/from Galaxy. Would be nice if the qiime wrappers output html outputs such as these by default, but until then this at least provides a way for users now to view qiime qzv outputs?

@bernt-matthias
Copy link
Contributor Author

I just wrote this exact same tool, then found this PR. What are your thoughts on this currently? Should we try to get this in?

Sorry for that. We should have merged this a long time ago. Lets go ahead.

Any comments from your side?

@shiltemann
Copy link
Member

@bernt-matthias ok great, just tested your tool locally and looks good to me 👍

@shiltemann shiltemann marked this pull request as ready for review May 13, 2024 08:44
@shiltemann shiltemann merged commit 19abce8 into galaxyproject:main May 13, 2024
@bernt-matthias bernt-matthias deleted the topic/qiime-qzv-vis branch May 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants